Change in osmo-pcu[master]: rlcmac: Return error code from csn1 encoder/decoder

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Feb 5 14:24:08 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17085 )

Change subject: rlcmac: Return error code from csn1 encoder/decoder
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

Not critical though.

https://gerrit.osmocom.org/c/osmo-pcu/+/17085/2/src/gsm_rlcmac.cpp 
File src/gsm_rlcmac.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17085/2/src/gsm_rlcmac.cpp@5114 
PS2, Line 5114: ret = -1;
Not addressed.


https://gerrit.osmocom.org/c/osmo-pcu/+/17085/2/src/gsm_rlcmac.cpp@5215 
PS2, Line 5215: ret = -1;
Not addressed.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17085
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0c5e1b870608b0622b239791effd5c5878e230bc
Gerrit-Change-Number: 17085
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Feb 2020 14:24:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200205/4bbf3f68/attachment.htm>


More information about the gerrit-log mailing list