Change in osmo-pcu[master]: rlcmac: Return error code from csn1 encoder/decoder

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Feb 4 23:53:04 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17085 )

Change subject: rlcmac: Return error code from csn1 encoder/decoder
......................................................................


Patch Set 1: Code-Review+1

(5 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/17085/1/src/gsm_rlcmac.cpp 
File src/gsm_rlcmac.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17085/1/src/gsm_rlcmac.cpp@4821 
PS1, Line 4821: -1
CSN_ERROR_GENERAL


https://gerrit.osmocom.org/c/osmo-pcu/+/17085/1/src/gsm_rlcmac.cpp@4942 
PS1, Line 4942: -1
CSN_ERROR_GENERAL


https://gerrit.osmocom.org/c/osmo-pcu/+/17085/1/src/gsm_rlcmac.cpp@5114 
PS1, Line 5114: -1
CSN_ERROR_GENERAL

Also, would be nice to print a error message here (idea for a separate patch).


https://gerrit.osmocom.org/c/osmo-pcu/+/17085/1/src/gsm_rlcmac.cpp@5215 
PS1, Line 5215: -1
same


https://gerrit.osmocom.org/c/osmo-pcu/+/17085/1/src/gsm_rlcmac.cpp@5219 
PS1, Line 5219: ret > 0
Is this even possible in case of encoding?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17085
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0c5e1b870608b0622b239791effd5c5878e230bc
Gerrit-Change-Number: 17085
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 23:53:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200204/1e5ce0a2/attachment.htm>


More information about the gerrit-log mailing list