Change in libosmocore[master]: tdef_vty: do not enforce enum 'node_type' in osmo_tdef_vty_groups_init()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Feb 4 18:57:28 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17017 )

Change subject: tdef_vty: do not enforce enum 'node_type' in osmo_tdef_vty_groups_init()
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > is that ebcause app-specific nodes use negative values?
> 
> No, the point is that they're not a part of node_type enum (their values are greater, AFAIR starting from NODE_TYPE_MAX + 1).

If the values are greater, shouldn't then it be an unsigned int instead of an int?


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17017
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifb4c406c85d76a25fc53fc235484599aa87dc77c
Gerrit-Change-Number: 17017
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Feb 2020 18:57:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200204/d25a59f7/attachment.htm>


More information about the gerrit-log mailing list