Change in libosmocore[master]: value_string: Switch val from unsigned to int

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17089 )

Change subject: value_string: Switch val from unsigned to int
......................................................................

value_string: Switch val from unsigned to int

There's nothing really preventing a user from user negative values.

Otherwise if we keep it like this then g++ is not happy when passing eg.
{ -2, "foobar" } when initializing a value_string array.

Change-Id: I754fa7e054cb89801ef82edc82199dcfbe59c6ab
---
M include/osmocom/core/utils.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  daniel: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h
index 01c4de6..40f4446 100644
--- a/include/osmocom/core/utils.h
+++ b/include/osmocom/core/utils.h
@@ -40,7 +40,7 @@
 
 /*! A mapping between human-readable string and numeric value */
 struct value_string {
-	unsigned int value;	/*!< numeric value */
+	int value;		/*!< numeric value */
 	const char *str;	/*!< human-readable string */
 };
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17089
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I754fa7e054cb89801ef82edc82199dcfbe59c6ab
Gerrit-Change-Number: 17089
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200204/949ddbe6/attachment.htm>