This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15487 ) Change subject: gprs_gmm_fsm.c: Implement RAT change between 2g and 3g ...................................................................... Patch Set 13: (5 comments) https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/12/src/sgsn/gprs_gmm.c File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/12/src/sgsn/gprs_gmm.c@1119 PS12, Line 1119: if (MSG_IU_UE_CTX(msg) && mmctx->ran_type != MM_CTX_T_UTRAN_Iu) > rat_chg.new_ran_type = MSG_IU_CTX(msg) ? Iu : Geran […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/12/src/sgsn/gprs_gmm.c@1257 PS12, Line 1257: ctx && > ctx is always valid here Done https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/12/src/sgsn/gprs_gmm.c@1641 PS12, Line 1641: if (!mmctx_did_rat_change(mmctx, msg)) > Add a comment: Rat changes will trigger the E_GMM_COMMON_PROC_INIT_REQ later, protect it here from c […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/12/src/sgsn/gprs_gmm.c@1675 PS12, Line 1675: mmctx > mmctx is always valid here. Done https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/12/src/sgsn/gprs_gmm_fsm.c File src/sgsn/gprs_gmm_fsm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/12/src/sgsn/gprs_gmm_fsm.c@173 PS12, Line 173: if (rat_chg->llme) > this if is not needed, llme should always be there in this case. Add an asert if you want. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3fc614da6ba137e871ee0fe86ca22b6a4a354dd2 Gerrit-Change-Number: 15487 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 04 Feb 2020 09:10:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200204/2cc4566a/attachment.htm>