Change in libosmocore[master]: value_string: Switch val from unsigned to int

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Feb 3 18:48:41 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/17089 )


Change subject: value_string: Switch val from unsigned to int
......................................................................

value_string: Switch val from unsigned to int

There's nothing really preventing a user from user negative values.

Otherwise if we keep it like this then g++ is not happy when passing eg.
{ -2, "foobar" } when initializing a value_string array.

Change-Id: I754fa7e054cb89801ef82edc82199dcfbe59c6ab
---
M include/osmocom/core/utils.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/17089/1

diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h
index 01c4de6..6f76e71 100644
--- a/include/osmocom/core/utils.h
+++ b/include/osmocom/core/utils.h
@@ -40,7 +40,7 @@
 
 /*! A mapping between human-readable string and numeric value */
 struct value_string {
-	unsigned int value;	/*!< numeric value */
+	int value;	/*!< numeric value */
 	const char *str;	/*!< human-readable string */
 };
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17089
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I754fa7e054cb89801ef82edc82199dcfbe59c6ab
Gerrit-Change-Number: 17089
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200203/0bb9f9e5/attachment.htm>


More information about the gerrit-log mailing list