Change in osmo-bsc[master]: vty: fix NULL-pointer dereference in cfg_bts_rep_dl_facch()

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21909 )

Change subject: vty: fix NULL-pointer dereference in cfg_bts_rep_dl_facch()
......................................................................

vty: fix NULL-pointer dereference in cfg_bts_rep_dl_facch()

There is only one parameter in command:

  repeat dl-facch (command|all)

so indeed argv[0] must be used instead of argv[1].

Change-Id: I01efff109a33791e13b0149fc47c792d3266da71
Related: SYS#5114
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 5692646..f4d2b82 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -2760,7 +2760,7 @@
 		return CMD_WARNING;
 	}
 
-	if (!strcmp(argv[1], "command")) {
+	if (!strcmp(argv[0], "command")) {
 	        bts->repeated_acch_policy.dl_facch_cmd = true;
 	        bts->repeated_acch_policy.dl_facch_all = false;
 	} else {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21909
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I01efff109a33791e13b0149fc47c792d3266da71
Gerrit-Change-Number: 21909
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201231/2f72ac75/attachment.htm>