Change in osmo-bts[master]: rsl: remove redundant boolean flag in rsl_rx_chan_activ()

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/21908 )


Change subject: rsl: remove redundant boolean flag in rsl_rx_chan_activ()
......................................................................

rsl: remove redundant boolean flag in rsl_rx_chan_activ()

Checking if a given RSL IE is present is a straightforward task,
so there is no need for a special boolean flag.

Change-Id: I6a12930314c79b9c3efabfa575b17f78105fea4c
---
M src/common/rsl.c
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/08/21908/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index f7f336a..ef23039 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1124,7 +1124,6 @@
 	struct tlv_parsed tp;
 	uint8_t type;
 	int rc;
-	bool ms_power_present = false;
 
 	if (lchan->state != LCHAN_S_NONE) {
 		LOGPLCHAN(lchan, DRSL, LOGL_ERROR, "error: lchan is not available, but in state: %s.\n",
@@ -1229,7 +1228,6 @@
 	if (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1)) {
 		lchan->ms_power_ctrl.max = *TLVP_VAL(&tp, RSL_IE_MS_POWER) & 0x1F;
 		lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;
-		ms_power_present = true;
 	}
 	/* 9.3.24 Timing Advance */
 	if (TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1))
@@ -1366,7 +1364,7 @@
 	switch (type) {
 	case RSL_ACT_INTER_ASYNC:
 	case RSL_ACT_INTER_SYNC:
-		lchan->want_dl_sacch_active = ms_power_present;
+		lchan->want_dl_sacch_active = TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1);
 		break;
 	default:
 		lchan->want_dl_sacch_active = true;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21908
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6a12930314c79b9c3efabfa575b17f78105fea4c
Gerrit-Change-Number: 21908
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201230/a481e395/attachment.htm>