Change in pysim[master]: sysmoISIM-SJA2: Add support for programming IMS Home Network Domain Name

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 29 20:24:17 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/21866 )

Change subject: sysmoISIM-SJA2: Add support for programming IMS Home Network Domain Name
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/21866/3/pySim/cards.py 
File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/21866/3/pySim/cards.py@1252 
PS3, Line 1252: elif p.get('mcc') and p.get('mnc'):
              : 					sw = self.update_domain(mcc=p['mcc'], mnc=p['mnc'])
here it's again a question if we should update/overwrite the file by default, even if the user doesn't tell us to do so at the command line...



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/21866
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3c823203aee88734ae423e4ad73da1027a4eaeed
Gerrit-Change-Number: 21866
Gerrit-PatchSet: 3
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 29 Dec 2020 20:24:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201229/4969752b/attachment.htm>


More information about the gerrit-log mailing list