Change in osmo-bsc[master]: abis_om2000: keep OM2K FSMs around, don't terminate

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 29 20:11:05 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21829 )

Change subject: abis_om2000: keep OM2K FSMs around, don't terminate
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c 
File src/osmo-bsc/abis_om2000.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c@2310 
PS1, Line 2310: 	trx->rbs2000.trx_fi = fi;
> My original idea was to do as much as possible inside the function, to avoid having to repeat the sa […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c@2326 
PS1, Line 2326: 	if (strcmp(osmo_fsm_inst_state_name(bts_fi), "DONE") &&
> Just move the enum to the fsm header file. […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c@2340 
PS1, Line 2340: 	if (strcmp(osmo_fsm_inst_state_name(bts_fi), "DONE") &&
> same, check against enum.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21829
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia37cffff5c451e1d79a52ccae41ab5718b4661d4
Gerrit-Change-Number: 21829
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Dec 2020 20:11:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201229/bb9b87bc/attachment.htm>


More information about the gerrit-log mailing list