Change in osmo-bsc[master]: Add a bts_model->bts_init() and trx_init() call-back function

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21825 )

Change subject: Add a bts_model->bts_init() and trx_init() call-back function
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/21825/1/src/osmo-bsc/bts.c 
File src/osmo-bsc/bts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21825/1/src/osmo-bsc/bts.c@498 
PS1, Line 498: 	if (model->start && !model->started) {
> Is it expected that we first call .start() and then . […]
the start function is a start function of the _model_. It should probably be converted to a __constructor__.

So yes, the model must be initialized and/or started befor you can create/init/start a BTS of that model, I see no logic problem.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21825
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icbad9cdc12221c9ad997267d77e5414edcbac538
Gerrit-Change-Number: 21825
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Dec 2020 17:30:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201229/652cd8cf/attachment.htm>