Change in osmo-e1-hardware[master]: icE1usb fw: Expose error conditions from E1 driver

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715 )

Change subject: icE1usb fw: Expose error conditions from E1 driver
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715/5/firmware/ice40-riscv/icE1usb/e1.c 
File firmware/ice40-riscv/icE1usb/e1.c:

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715/5/firmware/ice40-riscv/icE1usb/e1.c@356 
PS5, Line 356: /* get cumulative error bit mask since last call of this function */
> Huh, it's not "since the last call" AFAICT this is never reset. Counters just wrap.
indeed, I changed the code from an earlier implementation without fixing the comment.


https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715/5/firmware/ice40-riscv/icE1usb/e1.c@380 
PS5, Line 380: 		if (g_e1.rx.last_tick == cur_tick) {
> Again, as in previous patches, I'd remove any kind of support for LOS until there is actual hw to de […]
Ack


https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715/5/firmware/ice40-riscv/icE1usb/ice1usb_proto.h 
File firmware/ice40-riscv/icE1usb/ice1usb_proto.h:

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715/5/firmware/ice40-riscv/icE1usb/ice1usb_proto.h@83 
PS5, Line 83: #define ICE1USB_ERR_F_TICK_ERR	0x02
> I would call that LOS and not TICK_ERR. […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Iba3e00a2b28a2fef6dbd986bfc706c1619c3a3ed
Gerrit-Change-Number: 21715
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Sun, 27 Dec 2020 17:57:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt at 246tNt.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201227/8a19f125/attachment.htm>