Change in osmo-e1-hardware[master]: icE1usb fw: Turn green LED off completely if no E1 signal is received

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Dec 27 13:05:47 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21733 )

Change subject: icE1usb fw: Turn green LED off completely if no E1 signal is received
......................................................................


Patch Set 3:

> I have no idea yet if/how detection would work and it might turn out to not be based on that counter, so until the hw actually supports that, I wouldn't merge any related patch..

In theory I agree. However, this patch works in practice relatively well.  The green LED might occasionally flash/flicker, but in general it changes from a steady green to an 'almost always visually off'.  This is an improvement as now you have a direct visual indication if the cable is physically connected to the peer or not.

Yes, not super critical, but I found it extremely useful.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21733
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Ibd23cbf1d044b46d8fed48fb97622e6ef980b99f
Gerrit-Change-Number: 21733
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Sun, 27 Dec 2020 13:05:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201227/f5bbd148/attachment.htm>


More information about the gerrit-log mailing list