Change in libosmocore[master]: utils: add osmo-ns-dummy

[lynxis lazus]

lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21701 )

Change subject: utils: add osmo-ns-dummy
......................................................................


Patch Set 15:

(4 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21701/10/configure.ac 
File configure.ac:

https://gerrit.osmocom.org/c/libosmocore/+/21701/10/configure.ac@246 
PS10, Line 246: AC_ARG_ENABLE(nsdummy,
              : 	[AS_HELP_STRING(
              : 		[--enable-nsdummy],
              : 		[Enable building ns dummy for testing network service]
              : 	)],
              : 	[enable_nsdummy=$enableval], [enable_nsdummy="no"])
              : AM_CONDITIONAL(ENABLE_NSDUMMY, test x"$enable_nsdummy" = 
> if this is something needed for vty tests only, I would make its compilation depend on whether tests […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/21701/10/utils/Makefile.am 
File utils/Makefile.am:

https://gerrit.osmocom.org/c/libosmocore/+/21701/10/utils/Makefile.am@29 
PS10, Line 29: b
> should this be a noinst_PROGRAMS?  If all we do is use it for unit tests?  Installation would only m […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/21701/12/utils/osmo-ns-dummy.c 
File utils/osmo-ns-dummy.c:

https://gerrit.osmocom.org/c/libosmocore/+/21701/12/utils/osmo-ns-dummy.c@29 
PS12, Line 29: static char *config_file = "osmo-pcu.cfg";
> osmo-pcu?
Done


https://gerrit.osmocom.org/c/libosmocore/+/21701/14/utils/osmo-ns-dummy.c 
File utils/osmo-ns-dummy.c:

https://gerrit.osmocom.org/c/libosmocore/+/21701/14/utils/osmo-ns-dummy.c@221 
PS14, Line 221: 			       OSMO_VTY_PORT_PCU);
is this one ok? Should I really add a port for a test utility?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21701
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I127c178426bc1a3da8de251740eda93853030d6d
Gerrit-Change-Number: 21701
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 26 Dec 2020 15:12:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201226/800cb7b2/attachment.htm>