Change in osmo-bsc[master]: power_control: add increase / reduce step size recommendations

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21873 )


Change subject: power_control: add increase / reduce step size recommendations
......................................................................

power_control: add increase / reduce step size recommendations

Change-Id: I82e762c0c2b5e0dd739850ee494ab0a798e353de
Related: SYS#4918
---
M src/osmo-bsc/bsc_vty.c
M tests/power_ctrl.vty
2 files changed, 25 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/21873/1

diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 3cb479d..c106319 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4953,15 +4953,33 @@
 	      "Step size (2 or 4 dB)\n")
 {
 	struct gsm_power_ctrl_params *params = vty->index;
+	int inc_step_size_db = atoi(argv[0]);
+	int red_step_size_db = atoi(argv[1]);
 
-	if (atoi(argv[0]) % 2 || atoi(argv[1]) % 2) {
+	if (inc_step_size_db % 2 || red_step_size_db % 2) {
 		vty_out(vty, "%% Power change step size must be "
 			"an even number%s", VTY_NEWLINE);
 		return CMD_WARNING;
 	}
 
-	params->inc_step_size_db = atoi(argv[0]);
-	params->red_step_size_db = atoi(argv[1]);
+	/* Recommendation: POW_RED_STEP_SIZE <= POW_INCR_STEP_SIZE */
+	if (red_step_size_db > inc_step_size_db) {
+		vty_out(vty, "%% Increase step size (%d) should be greather "
+			"than reduce step size (%d), consider changing it%s",
+			inc_step_size_db, red_step_size_db, VTY_NEWLINE);
+	}
+
+	/* Recommendation: POW_INCR_STEP_SIZE <= (U_RXLEV_XX_P - L_RXLEV_XX_P) */
+	const struct gsm_power_ctrl_meas_params *mp = &params->rxlev_meas;
+	if (inc_step_size_db > (mp->upper_thresh - mp->lower_thresh)) {
+		vty_out(vty, "%% Increase step size (%d) should be less or equal "
+			"than/to the RxLev threshold window (%d, upper - lower), "
+			"consider changing it%s", inc_step_size_db,
+			mp->upper_thresh - mp->lower_thresh, VTY_NEWLINE);
+	}
+
+	params->inc_step_size_db = inc_step_size_db;
+	params->red_step_size_db = red_step_size_db;
 
 	return CMD_SUCCESS;
 }
diff --git a/tests/power_ctrl.vty b/tests/power_ctrl.vty
index d58c075..4fa416f 100644
--- a/tests/power_ctrl.vty
+++ b/tests/power_ctrl.vty
@@ -131,6 +131,9 @@
 OsmoBSC(config-ms-power-ctrl)# step-size inc 2 red 3
 % Power change step size must be an even number
 OsmoBSC(config-ms-power-ctrl)# step-size inc 2 red 4
+% Increase step size (2) should be greather than reduce step size (4), consider changing it
+
+OsmoBSC(config-ms-power-ctrl)# step-size inc 6 red 4
 OsmoBSC(config-ms-power-ctrl)# show running-config
 ...
   bs-power-control
@@ -140,7 +143,7 @@
 ...
   ms-power-control
    mode dyn-bts
-   step-size inc 2 red 4
+   step-size inc 6 red 4
 ...
 
 OsmoBSC(config-ms-power-ctrl)# rxlev-thresh lower?

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21873
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I82e762c0c2b5e0dd739850ee494ab0a798e353de
Gerrit-Change-Number: 21873
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201224/9ca32d6b/attachment.htm>