This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13422 ) Change subject: Autofill LCLS parameters for A-interface transactions ...................................................................... Patch Set 12: (9 comments) https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/include/osmocom/msc/mncc.h File include/osmocom/msc/mncc.h: https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/include/osmocom/msc/mncc.h@166 PS12, Line 166: > Need to bump the MNCC version. @laforge, this is the reason why this patch must remain WIP, it changes the MNCC socket protocol without bumping the revision (which should also be coordinated with osmo-sip-connector) https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/include/osmocom/msc/transaction.h File include/osmocom/msc/transaction.h: https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/include/osmocom/msc/transaction.h@135 PS12, Line 135: struct osmo_lcls *lcls; this should go in the "cc" struct above, because it only concerns voice transactions https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/include/osmocom/msc/vlr.h File include/osmocom/msc/vlr.h: https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/include/osmocom/msc/vlr.h@274 PS12, Line 274: bool lcls_enable; i don't see this flag being used anywhere. It gets initialized to 1 at some point but never has any effect, right? (also, the VLR is not the right place to put an LCLS flag) I think we can drop the flag until a need arises... https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/src/libmsc/gsm_04_08_cc.c@503 PS12, Line 503: trans->lcls = trans_lcls_compose(trans, true); (if (!trans->lcls), log a comment that composing LCLS info failed?) https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/src/libmsc/gsm_04_08_cc.c@1984 PS12, Line 1984: trans->lcls->gcr = trans->cc.msg.gcr; > Might be worth placing in a comment here that this is happing as a result of Paging success, so we n […] imho above comment is sufficient https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/src/libmsc/mncc_builtin.c File src/libmsc/mncc_builtin.c: https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/src/libmsc/mncc_builtin.c@72 PS12, Line 72: struct osmo_gcr_parsed gcr) setup->gcr == gcr, there should be no need to add another argument. (BTW, passing a struct as argument must always be done as a pointer) https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/src/libmsc/mncc_builtin.c@116 PS12, Line 116: setup->gcr = gcr; afaict the same gcr is already in there, just leave it up to the caller and not bother here https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/src/libmsc/mncc_builtin.c@310 PS12, Line 310: rc = mncc_setup_ind(call, arg, data->gcr); arg and data are pointers to the same MNCC struct, it shouldn't be necessary to add another arg https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/src/libmsc/transaction.c File src/libmsc/transaction.c: https://gerrit.osmocom.org/c/osmo-msc/+/13422/12/src/libmsc/transaction.c@117 PS12, Line 117: Can we get primary_pc elsewhere? */ > Not sure this commment is still valid. […] i think this comment can be dropped, doesn't seem to convey any useful information -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I35ae6b6ca04925c8d300bc1a0269af00eac727f3 Gerrit-Change-Number: 13422 Gerrit-PatchSet: 12 Gerrit-Owner: Max <suraev at alumni.ntnu.no> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Wed, 23 Dec 2020 20:31:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <keith at rhizomatica.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201223/3e328471/attachment.htm>