Change in libosmocore[master]: rest_octets: Fix decoding of SI3 3G Early Classmark Sending Restriction

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Dec 23 12:39:19 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21818 )

Change subject: rest_octets: Fix decoding of SI3 3G Early Classmark Sending Restriction
......................................................................

rest_octets: Fix decoding of SI3 3G Early Classmark Sending Restriction

Restriction is applied if the value is L, so fix it.

Fixes: f85b33f68fcf9b34e723e4571078d7eeb0de5d59
Change-Id: Idd170bc0f12e8b215a624e0632a106bde076179b
---
M src/gsm/gsm48_rest_octets.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index 90f2b03..b2b37b3 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -1063,9 +1063,9 @@
 	/* 3G Early Classmark Sending Restriction. If H, then controlled by
 	 * early_cm_ctrl above */
 	if (bitvec_get_bit_high(&bv) == H)
-		si3->early_cm_restrict_3g = 1;
-	else
 		si3->early_cm_restrict_3g = 0;
+	else
+		si3->early_cm_restrict_3g = 1;
 
 	if (bitvec_get_bit_high(&bv) == H)
 		si3->si2quater_indicator = 1;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21818
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idd170bc0f12e8b215a624e0632a106bde076179b
Gerrit-Change-Number: 21818
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201223/0e83413c/attachment.htm>


More information about the gerrit-log mailing list