Change in libosmocore[master]: frame_relay: link_alloc: move log message to the end

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Wed Dec 23 11:27:13 UTC 2020


lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21844 )

Change subject: frame_relay: link_alloc: move log message to the end
......................................................................

frame_relay: link_alloc: move log message to the end

The link->name is still not set resulting in logging a (null)

Change-Id: I67cd4bce8238340e6ecb8d04a9a39c8b8d7d63e7
---
M src/gb/frame_relay.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/gb/frame_relay.c b/src/gb/frame_relay.c
index 0304882..3a51700 100644
--- a/src/gb/frame_relay.c
+++ b/src/gb/frame_relay.c
@@ -880,9 +880,6 @@
 	struct osmo_fr_link *link = talloc_zero(net, struct osmo_fr_link);
 	if (!link)
 		return NULL;
-
-	LOGPFRL(link, LOGL_INFO, "Creating frame relay link with role %s\n", osmo_fr_role_str(role));
-
 	link->role = role;
 	link->net = net;
 	link->name = talloc_strdup(link, name);
@@ -901,6 +898,8 @@
 		break;
 	}
 
+	LOGPFRL(link, LOGL_INFO, "Creating frame relay link with role %s\n", osmo_fr_role_str(role));
+
 	return link;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21844
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I67cd4bce8238340e6ecb8d04a9a39c8b8d7d63e7
Gerrit-Change-Number: 21844
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201223/20aea258/attachment.htm>


More information about the gerrit-log mailing list