Change in libosmocore[master]: gprs_ns2: fix force-unconfigured for IP-SNS NSE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Wed Dec 23 11:27:11 UTC 2020


lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21841 )

Change subject: gprs_ns2: fix force-unconfigured for IP-SNS NSE
......................................................................

gprs_ns2: fix force-unconfigured for IP-SNS NSE

The IP-SNS need to do a reselection of the IP-SNS remote
for testing. Freeing all nsvc will force this.

Change-Id: I367c215a830c02eae2a470cba314828b5e0fb5c9
---
M src/gb/gprs_ns2_vty.c
M src/gb/gprs_ns2_vty2.c
2 files changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved



diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c
index 9e09f0d..065f3ad 100644
--- a/src/gb/gprs_ns2_vty.c
+++ b/src/gb/gprs_ns2_vty.c
@@ -440,8 +440,12 @@
 		return CMD_WARNING;
 	}
 
-	/* Perform the operation for all nsvc */
-	gprs_ns2_nse_foreach_nsvc(nse, nsvc_force_unconf_cb, NULL);
+	if (nse->dialect == NS2_DIALECT_SNS) {
+		gprs_ns2_free_nsvcs(nse);
+	} else {
+		/* Perform the operation for all nsvc */
+		gprs_ns2_nse_foreach_nsvc(nse, nsvc_force_unconf_cb, NULL);
+	}
 
 	return CMD_SUCCESS;
 }
diff --git a/src/gb/gprs_ns2_vty2.c b/src/gb/gprs_ns2_vty2.c
index 2ccc7ed..e8738c1 100644
--- a/src/gb/gprs_ns2_vty2.c
+++ b/src/gb/gprs_ns2_vty2.c
@@ -1491,8 +1491,12 @@
 		return CMD_WARNING;
 	}
 
-	/* Perform the operation for all nsvc */
-	gprs_ns2_nse_foreach_nsvc(nse, nsvc_force_unconf_cb, NULL);
+	if (nse->dialect == NS2_DIALECT_SNS) {
+		gprs_ns2_free_nsvcs(nse);
+	} else {
+		/* Perform the operation for all nsvc */
+		gprs_ns2_nse_foreach_nsvc(nse, nsvc_force_unconf_cb, NULL);
+	}
 
 	return CMD_SUCCESS;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21841
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I367c215a830c02eae2a470cba314828b5e0fb5c9
Gerrit-Change-Number: 21841
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201223/dbf335d7/attachment.htm>


More information about the gerrit-log mailing list