Change in libosmocore[master]: gprs_ns2: sns: correct log message when no nsvcs available

[lynxis lazus]

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21821 )

Change subject: gprs_ns2: sns: correct log message when no nsvcs available
......................................................................

gprs_ns2: sns: correct log message when no nsvcs available

The log message should only shown if a reselection will be triggered.

Change-Id: I96b280a927aba6ac09ce88aedfcf469243c4dffe
---
M src/gb/gprs_ns2_sns.c
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 4664a35..f0e587d 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -250,7 +250,6 @@
 				gss->sns_nsvc = tmp;
 		}
 	} else {
-		LOGPFSML(fi, LOGL_ERROR, "NSE %d: no remaining NSVC, resetting SNS FSM\n", nse->nsei);
 		gss->sns_nsvc = NULL;
 		osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_NO_NSVC, NULL);
 	}
@@ -1337,8 +1336,12 @@
 	/* reset when receiving GPRS_SNS_EV_NO_NSVC */
 	switch (event) {
 	case GPRS_SNS_EV_NO_NSVC:
-		if (!gss->reselection_running)
-			osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_SELECT_ENDPOINT, NULL);
+		/* ignore reselection running */
+		if (gss->reselection_running)
+			break;
+
+		LOGPFSML(fi, LOGL_ERROR, "NSE %d: no remaining NSVC, resetting SNS FSM\n", nse->nsei);
+		osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_SELECT_ENDPOINT, NULL);
 		break;
 	case GPRS_SNS_EV_SELECT_ENDPOINT:
 		/* tear down previous state

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21821
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I96b280a927aba6ac09ce88aedfcf469243c4dffe
Gerrit-Change-Number: 21821
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201223/c3687768/attachment.htm>