Change in libosmocore[master]: gprs_ns2: add new vty2

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Dec 22 15:37:30 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21487 )

Change subject: gprs_ns2: add new vty2
......................................................................


Patch Set 23:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21487/18/include/osmocom/gprs/gprs_ns2.h 
File include/osmocom/gprs/gprs_ns2.h:

https://gerrit.osmocom.org/c/libosmocore/+/21487/18/include/osmocom/gprs/gprs_ns2.h@45 
PS18, Line 45: 	GPRS_NS2_LL_UNDEF,	/*!< undefined used by vty */
> So then please improve the description.
i've added a ",". hopefully it's ok this way.


https://gerrit.osmocom.org/c/libosmocore/+/21487/23/src/gb/gprs_ns2_vty2.c 
File src/gb/gprs_ns2_vty2.c:

https://gerrit.osmocom.org/c/libosmocore/+/21487/23/src/gb/gprs_ns2_vty2.c@1024 
PS23, Line 1024:       NSVCI_STR
> Seems those are repeated both for "nsvci" and the actual range. […]
you're right. I moved nsvci early today to the end.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21487
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I163279cf57e84198dc8c53e1c109f5a9474670e9
Gerrit-Change-Number: 21487
Gerrit-PatchSet: 23
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Dec 2020 15:37:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201222/ba429eda/attachment.htm>


More information about the gerrit-log mailing list