Change in libosmocore[master]: gprs_ns2: add new vty2

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Dec 22 14:53:26 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21487 )

Change subject: gprs_ns2: add new vty2
......................................................................


Patch Set 22:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21487/21/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/21487/21/src/gb/gprs_ns2_sns.c@1501 
PS21, Line 1501:  *  \param[in] nse NS Entity whose IP-SNS state shall be printed */
> Stats is still a parameter in this function
Done


https://gerrit.osmocom.org/c/libosmocore/+/21487/21/src/gb/gprs_ns2_sns.c@1540 
PS21, Line 1540:  *  \param[in] stats Whether or not statistics shall also be printed */
> Here it's not :-)
Done


https://gerrit.osmocom.org/c/libosmocore/+/21487/21/src/gb/libosmogb.map 
File src/gb/libosmogb.map:

https://gerrit.osmocom.org/c/libosmocore/+/21487/21/src/gb/libosmogb.map@167 
PS21, Line 167: gprs_ns2_vty2_init;
> Add a TODO_RELEASE entry to move vty2_init to vty_init? No use introducing a deprecated API right aw […]
i think the tdoo_release is wrong.
however you're right. i want to do another cleanup of the ns2 code bases before release.
e.g. renaming things of ns2. improve gprs_ns2 and ns2_ prefix.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21487
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I163279cf57e84198dc8c53e1c109f5a9474670e9
Gerrit-Change-Number: 21487
Gerrit-PatchSet: 22
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Dec 2020 14:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201222/9f8039bf/attachment.htm>


More information about the gerrit-log mailing list