This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21829 ) Change subject: abis_om2000: keep OM2K FSMs around, don't terminate ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c@2326 PS1, Line 2326: if (strcmp(osmo_fsm_inst_state_name(bts_fi), "DONE") && > yes, but that would mean the enum must be declared here already, which would mean that the enum defi […] Just move the enum to the fsm header file. It's not only about optimization, it's about saving one's ass if the FSM is extended/changed in the future and the name of the state changes. If an enum is used, the compiler will detect so and then one knows this code here needs to be adapted too. You can also add a function to the FSM file, something bool like bts_not_yet_brought_up(bts_fi). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia37cffff5c451e1d79a52ccae41ab5718b4661d4 Gerrit-Change-Number: 21829 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 22 Dec 2020 11:10:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201222/5b9fc021/attachment.htm>