Change in libosmocore[master]: gprs_ns2: don't start unconfigured fsm via FORCE_UNCONFIGURED

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/21824 )


Change subject: gprs_ns2: don't start unconfigured fsm via FORCE_UNCONFIGURED
......................................................................

gprs_ns2: don't start unconfigured fsm via FORCE_UNCONFIGURED

IP-SNS NSVC are unconfigured and not started when the IP-SNS is doing the SNS configuration.
If those NSVC would be started it would result in unsolicitated NS-Alive PDUs.

Change-Id: Ifec7288dbe71f10109e8b5c3849bf8f23ac7b557
---
M src/gb/gprs_ns2_vc_fsm.c
1 file changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/21824/1

diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c
index 0f6eeab..d5f134e 100644
--- a/src/gb/gprs_ns2_vc_fsm.c
+++ b/src/gb/gprs_ns2_vc_fsm.c
@@ -566,10 +566,12 @@
 		msgb_free(msg);
 		break;
 	case GPRS_NS2_EV_FORCE_UNCONFIGURED:
-		/* Force the NSVC back to its initial state */
-		osmo_fsm_inst_state_chg(fi, GPRS_NS2_ST_UNCONFIGURED, 0, 0);
-		osmo_fsm_inst_dispatch(fi, GPRS_NS2_EV_START, NULL);
-		return;
+		if (fi->state != GPRS_NS2_ST_UNCONFIGURED) {
+			/* Force the NSVC back to its initial state */
+			osmo_fsm_inst_state_chg(fi, GPRS_NS2_ST_UNCONFIGURED, 0, 0);
+			osmo_fsm_inst_dispatch(fi, GPRS_NS2_EV_START, NULL);
+			return;
+		}
 		break;
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21824
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifec7288dbe71f10109e8b5c3849bf8f23ac7b557
Gerrit-Change-Number: 21824
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201221/1ee73d9a/attachment.htm>