Change in osmo-bsc[master]: power_control: send default parameters from bootstrap_rsl()

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21788 )

Change subject: power_control: send default parameters from bootstrap_rsl()
......................................................................

power_control: send default parameters from bootstrap_rsl()

Thanks to this message, there is no need to include MS/BS Power
Control parameters in every RSL CHANnel ACTIvation message.
Instead, we send them only once, and then send empty IEs.

Change-Id: I46ae4e6003a1839ee57f8e941a54bf479f7e532d
Related: SYS#4918
---
M src/osmo-bsc/osmo_bsc_main.c
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index df5235e..4ab0430 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -310,6 +310,7 @@
 static void bootstrap_rsl(struct gsm_bts_trx *trx)
 {
 	unsigned int i;
+	int rc;
 
 	LOG_TRX(trx, DRSL, LOGL_NOTICE, "bootstrapping RSL "
 		"on ARFCN %u using MCC-MNC %s LAC=%u CID=%u BSIC=%u\n",
@@ -340,6 +341,15 @@
 		rsl_nokia_si_end(trx);
 	}
 
+	if (trx->bts->model->power_ctrl_send_def_params != NULL) {
+		rc = trx->bts->model->power_ctrl_send_def_params(trx);
+		if (rc) {
+			LOG_TRX(trx, DRSL, LOGL_ERROR, "Failed to send default "
+				"MS/BS Power control parameters (rc=%d)\n", rc);
+			/* TODO: should we drop RSL connection here? */
+		}
+	}
+
 	for (i = 0; i < ARRAY_SIZE(trx->ts); i++) {
 		struct gsm_bts_trx_ts *ts = &trx->ts[i];
 		generate_ma_for_ts(ts);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21788
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I46ae4e6003a1839ee57f8e941a54bf479f7e532d
Gerrit-Change-Number: 21788
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201221/53c78ede/attachment.htm>