Change in osmo-bsc[master]: power_control: add encoding/init API to 'struct gsm_bts_model'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Dec 21 12:37:01 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21792 )

Change subject: power_control: add encoding/init API to 'struct gsm_bts_model'
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/21792/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/21792/2//COMMIT_MSG@13 
PS2, Line 13: for CHANnel ACTIVation and MS/BS POWER CONTROL messages
power_ctrl_enc_rsl_params(): as you can see, it's also used for encoding MS/BS Power Control messages, so power_ctrl_enc_chan_act() would not be correct


https://gerrit.osmocom.org/c/osmo-bsc/+/21792/2//COMMIT_MSG@15 
PS2, Line 15: power_ctrl_send_def_params
I want to be able to re-send default parameters from the VTY, so power_ctrl_enc_rsl_up() also does not match up. We can of course generalize this somehow later, given that this is not a library. For now I would merge it as it is.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21792
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iba3ad5d8d549a6676050272f85b21c9b4c219d21
Gerrit-Change-Number: 21792
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Dec 2020 12:37:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201221/e4520b6f/attachment.htm>


More information about the gerrit-log mailing list