Change in osmo-e1-hardware[master]: icE1usb fw: Include E1 frame number in Rx USB header

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21717 )

Change subject: icE1usb fw: Include E1 frame number in Rx USB header
......................................................................

icE1usb fw: Include E1 frame number in Rx USB header

This should enable the host to detect discontinuities, and also know
when a multiframe starts.

Related: OS#4674
Change-Id: Ie0688647c56ebfc2e08de44f8ec569e1c2cd6a28
---
M firmware/ice40-riscv/icE1usb/usb_e1.c
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  tnt: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/firmware/ice40-riscv/icE1usb/usb_e1.c b/firmware/ice40-riscv/icE1usb/usb_e1.c
index 6bcb1b4..e37edc3 100644
--- a/firmware/ice40-riscv/icE1usb/usb_e1.c
+++ b/firmware/ice40-riscv/icE1usb/usb_e1.c
@@ -14,6 +14,7 @@
 
 #include "console.h"
 #include "misc.h"
+#include "e1.h"
 
 struct {
 	bool running;		/* are we running (transceiving USB data)? */
@@ -76,6 +77,7 @@
 	{
 		uint32_t ptr = usb_ep_regs[2].in.bd[bdi].ptr;
 		uint32_t hdr;
+		unsigned int pos;
 
 		/* Error check */
 		if ((usb_ep_regs[2].in.bd[bdi].csr & USB_BD_STATE_MSK) == USB_BD_STATE_DONE_ERR)
@@ -93,10 +95,10 @@
 		else if (!n)
 			break;
 
-		n = e1_rx_need_data((ptr >> 2) + 1, n, NULL);
+		n = e1_rx_need_data((ptr >> 2) + 1, n, &pos);
 
-		/* Write header */
-		hdr = 0x616b00b5;
+		/* Write header: currently version and pos (mfr/fr number) */
+		hdr = (0 << 28) | (pos & 0xff);
 		usb_data_write(ptr, &hdr, 4);
 
 		/* Resubmit */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21717
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Ie0688647c56ebfc2e08de44f8ec569e1c2cd6a28
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201220/90c097d0/attachment.htm>