Change in osmo-e1-hardware[master]: icE1usb fw: Use register bit #define instead of magic number

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Dec 20 23:20:21 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21707 )

Change subject: icE1usb fw: Use register bit #define instead of magic number
......................................................................

icE1usb fw: Use register bit #define instead of magic number

Change-Id: Ic824ce5a6605c96989fefbf92f365bff618dccb2
---
M firmware/ice40-riscv/icE1usb/e1.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  tnt: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c
index 776edba..5d4d3ee 100644
--- a/firmware/ice40-riscv/icE1usb/e1.c
+++ b/firmware/ice40-riscv/icE1usb/e1.c
@@ -406,7 +406,7 @@
 		return;
 
 	/* HACK: LED link status */
-	if (e1_regs->rx.csr & 2)
+	if (e1_regs->rx.csr & E1_RX_SR_ALIGNED)
 		led_color(0, 48, 0);
 	else
 		led_color(48, 0, 0);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21707
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Ic824ce5a6605c96989fefbf92f365bff618dccb2
Gerrit-Change-Number: 21707
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201220/cf635768/attachment.htm>


More information about the gerrit-log mailing list