Change in osmo-e1d[master]: Evaluate received E and A bits in TS0

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21808 )

Change subject: Evaluate received E and A bits in TS0
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/intf_line.c 
File src/intf_line.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/intf_line.c@55 
PS2, Line 55: 	[LINE_CTR_RX_REMOTE_E] ={ "rx:remote_crc_errors",	"Rx Frames reporting remote CRC Error"},
> Ack
FYI. that was probably my German brain.  Frames , CRC and Error are nouns and hence capitalized - reporting and remote as verb/adverb/adjective lowercase.


https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/vpair.c 
File src/vpair.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/vpair.c@135 
PS2, Line 135: 		rc = e1_line_demux_in(peer, buf, rc, 0);
> But all the TS0 processing will still happen and set flags and counters and all that stuff. […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/21808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I7e1c919518b3418e973b7ae5bedd5a6dd1c2adec
Gerrit-Change-Number: 21808
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Sun, 20 Dec 2020 11:32:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: tnt <tnt at 246tNt.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201220/f241139d/attachment.htm>