Change in osmo-e1d[master]: Evaluate received E and A bits in TS0

[tnt]

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21808 )

Change subject: Evaluate received E and A bits in TS0
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/intf_line.c 
File src/intf_line.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/intf_line.c@55 
PS2, Line 55: 	[LINE_CTR_RX_REMOTE_E] ={ "rx:remote_crc_errors",	"Rx Frames reporting remote CRC Error"},
Maybe try a bit of consistency in the capitalization. I don't care which but pick one style 😊


https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/mux_demux.c 
File src/mux_demux.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/mux_demux.c@370 
PS2, Line 370: 			crc4_err ? "STARTED" : "CEASED");
Is CRC error really a "condition" ? (i.e. something that starts and cease).
They are really per frame, just like our local CRC checks.
And even random data would end up passing CRC 25% of the time, so if you wanted to report repeated CRC errors as a status, it would IMHO need some minimal software denounce.


https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/vpair.c 
File src/vpair.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/vpair.c@135 
PS2, Line 135: 		rc = e1_line_demux_in(peer, buf, rc, 0);
Why 0 ?
AFAICT frames_expired doesn't especially keep alignement to multiframe boundaries.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/21808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I7e1c919518b3418e973b7ae5bedd5a6dd1c2adec
Gerrit-Change-Number: 21808
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Sat, 19 Dec 2020 21:40:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201219/7ae6e707/attachment.htm>