Change in osmo-bsc[master]: power_control: send RSL_IE_{MS, BS}_POWER_PARAM on CHANnel ACTIVation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Dec 18 18:10:49 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21787 )

Change subject: power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel ACTIVation
......................................................................


Patch Set 1:

> Or for instance put the initial IE setup in the the ipacc_tx_..._def you are adding in the last commit, and use the function pointer you add in this commit as the "channel activ" one.

I actually found a problem in rsl_tx_ipacc_meas_preproc_def(): it would always send empty MS/BS Parameters :/  Thanks for directing my attention towards this part of the code.

> It's all even more confusing because you spread all this through different commits. Just sharing my opinion in case you want to give it another thought.

I agree that the current order is confusing, so I'll rework the patch set and reorder changes in a more readable way.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4
Gerrit-Change-Number: 21787
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Dec 2020 18:10:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201218/48bf56a9/attachment.htm>


More information about the gerrit-log mailing list