Change in libosmocore[master]: gprs_ns2: fr: implement a write queue

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Dec 17 12:57:10 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21751 )

Change subject: gprs_ns2: fr: implement a write queue
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21751/2/src/gb/gprs_ns2_fr.c 
File src/gb/gprs_ns2_fr.c:

https://gerrit.osmocom.org/c/libosmocore/+/21751/2/src/gb/gprs_ns2_fr.c@244 
PS2, Line 244: 	return write(ofd->fd, msgb_data(msg), msgb_length(msg));
Don't you need to free msg here?


https://gerrit.osmocom.org/c/libosmocore/+/21751/2/src/gb/gprs_ns2_fr.c@515 
PS2, Line 515: 	priv->wqueue.bfd.fd = rc = open_socket(priv->ifindex);
we have osmo_ofd_setup() for this.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21751
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id6eba04d5fb744f791b333c168729bbbd28cabd9
Gerrit-Change-Number: 21751
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Dec 2020 12:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201217/6d21769b/attachment.htm>


More information about the gerrit-log mailing list