Change in libosmocore[master]: gprs_bssgp: add handling for BSSGP RIM primitives

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21722 )

Change subject: gprs_bssgp: add handling for BSSGP RIM primitives
......................................................................


Patch Set 2:

(4 comments)

(ensure comments are sent)

https://gerrit.osmocom.org/c/libosmocore/+/21722/1/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/21722/1/include/osmocom/gprs/gprs_bssgp.h@59 
PS1, Line 59: 	PRIM_BSSGP_RIM
> Add , at the end.
Done


https://gerrit.osmocom.org/c/libosmocore/+/21722/1/src/gb/gprs_bssgp.c 
File src/gb/gprs_bssgp.c:

https://gerrit.osmocom.org/c/libosmocore/+/21722/1/src/gb/gprs_bssgp.c@707 
PS1, Line 707: truct bssgp_normal_hdr *bgph =
             : 	    (struct b
> no line break needed [not critical]
Done


https://gerrit.osmocom.org/c/libosmocore/+/21722/1/src/gb/gprs_bssgp.c@711 
PS1, Line 711: PDU
> likewise here  this looks like it can fit in a single line with our current limit of 120?
This is old code, with 80 col limit - I don't know exactly how we agreed on this. As far as I know old code should be continued with 80 col limit.


https://gerrit.osmocom.org/c/libosmocore/+/21722/1/src/gb/gprs_bssgp.c@728 
PS1, Line 728: 	/
> comment doesn't match code
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21722
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idfd0a65872a2cc6089885afd8d31b0b029d85d47
Gerrit-Change-Number: 21722
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Dec 2020 14:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201216/79062295/attachment.htm>