Change in osmo-sgsn[master]: sgsn: Use the new NS2 api

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 15 18:49:31 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 )

Change subject: sgsn: Use the new NS2 api
......................................................................


Patch Set 11: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c 
File src/sgsn/gprs_gb.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c@117 
PS11, Line 117: 	osmo_prim_init(&nsp.oph, SAP_NS, PRIM_NS_UNIT_DATA,
no line break needed, here and in many other occasions, at least that's my feeling


https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c@143 
PS11, Line 143: 		LOGP(DGPRS, LOGL_NOTICE,
no line break needed (at leat not for four lines), here and in many other occasions, at least that's my feeling


https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c@184 
PS11, Line 184: 		     get_value_string(osmo_prim_op_names, oph->operation),
likewise



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d
Gerrit-Change-Number: 20397
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 15 Dec 2020 18:49:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201215/c291d368/attachment.htm>


More information about the gerrit-log mailing list