Change in osmo-gsm-tester[master]: ctrl: set socket timeout

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Dec 10 23:42:10 UTC 2020


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21518 )

Change subject: ctrl: set socket timeout
......................................................................

ctrl: set socket timeout

The blocking CTRL socket must have a timeout.

So far we have always been reading from the CTRL socket in a blocking
way. So far we are always lucky that we are indeed getting a response to
receive. Should the CTRL interface ever fail to answer, the tester would
be stuck infinitely.

Change-Id: I20091daf13981dc3d0d894af5a65c23f4db0471d
---
M src/osmo_gsm_tester/obj/osmo_ctrl.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/obj/osmo_ctrl.py b/src/osmo_gsm_tester/obj/osmo_ctrl.py
index 312e1e9..891cc48 100644
--- a/src/osmo_gsm_tester/obj/osmo_ctrl.py
+++ b/src/osmo_gsm_tester/obj/osmo_ctrl.py
@@ -55,6 +55,7 @@
         self.sck = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
         self.sck.connect((self.host, self.port))
         self.sck.setblocking(1)
+        self.sck.settimeout(10)
 
     def disconnect(self):
         self.dbg('Disconnecting')

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21518
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I20091daf13981dc3d0d894af5a65c23f4db0471d
Gerrit-Change-Number: 21518
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201210/e8b001ee/attachment.htm>


More information about the gerrit-log mailing list