Change in libosmocore[master]: logging: Introduce DLBSSGP logging constant

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21597 )

Change subject: logging: Introduce DLBSSGP logging constant
......................................................................


Patch Set 4:

(1 comment)

> > DBSSGP in src/gb/common_vty.{c,h} is unused now, we can remove it.
> 
> If you do that, all extrenal code using it will break. That would be osmo-sgsn, osmo-gbproxy and osmo-pcu.  We need to convert those over to DLBSSGP first, and then we can remove them.  I'll add ac omment

actually , you are right. The applications define those integer symbols themselves and then hand them into the library via this API.  So it can be removed.

https://gerrit.osmocom.org/c/libosmocore/+/21597/4/src/gb/gprs_bssgp.c 
File src/gb/gprs_bssgp.c:

https://gerrit.osmocom.org/c/libosmocore/+/21597/4/src/gb/gprs_bssgp.c@1356 
PS4, Line 1356: 	LOGP(DLGLOBAL, LOGL_ERROR, "BSSGP has moved from DGPRS to DLGPRS, please update your code\n");
> We should also mark it as OSMO_DEPRECATED() in gprs/gprs_bssgp. […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21597
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
Gerrit-Change-Number: 21597
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Wed, 09 Dec 2020 21:45:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201209/052c357d/attachment.htm>