This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21447 ) Change subject: power_control: implement BS (Downlink) Power Control ...................................................................... Patch Set 5: (4 comments) https://gerrit.osmocom.org/c/osmo-bts/+/21447/5//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/21447/5//COMMIT_MSG@28 PS5, Line 28: trigger the logic to reduce the current attenuation twice. > iirc from code you are /2, so this "reduce twice" actually means divide by two? Hmm, I am actually not sure how to say/write this correctly... Should I change to "divide by two"? https://gerrit.osmocom.org/c/osmo-bts/+/21447/5/src/common/power_control.c File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/21447/5/src/common/power_control.c@283 PS5, Line 283: * > because empty lines are free! ;) Well, my intention is to separate formulas from text visually. https://gerrit.osmocom.org/c/osmo-bts/+/21447/5/src/common/power_control.c@295 PS5, Line 295: new = state->current - delta; > better use a another variable name (C++, syntax highlight, etc. […] This is not a header file, so I don't think we will have any problems (other than syntax highlighting). https://gerrit.osmocom.org/c/osmo-bts/+/21447/5/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/21447/5/src/common/rsl.c@1162 PS5, Line 1162: lchan->bs_power_ctrl.max = 2 * 15; > where does this come from? 2 * 15 >From the definition of BS Power IE: 0 .. 15 (2 dB steps). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5b509e71d5f668b6b8b2abf8053c27f2a7c78451 Gerrit-Change-Number: 21447 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 07 Dec 2020 14:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201207/d46538b7/attachment.htm>