Change in osmo-gsm-tester[master]: add osmo_vty.py

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Dec 7 10:23:40 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504 )

Change subject: add osmo_vty.py
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/1/src/osmo_gsm_tester/obj/osmo_vty.py 
File src/osmo_gsm_tester/obj/osmo_vty.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/1/src/osmo_gsm_tester/obj/osmo_vty.py@44 
PS1, Line 44:     def connect(self):
> ok, will add. […]
You sed you'd add but I don't see the comments with (PROTECTED, PUBLIC - INTERNAL API, PUBLIC (test API included)) and each function under its corresponding section.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/3/src/osmo_gsm_tester/obj/osmo_vty.py 
File src/osmo_gsm_tester/obj/osmo_vty.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504/3/src/osmo_gsm_tester/obj/osmo_vty.py@64 
PS3, Line 64:             self.sck = None
is socket closed whenever you set it to None? I'd prefer having an explicitly sck.close() here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21504
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I7c17b143b7c690b8c4105ee7c6272670046fa91d
Gerrit-Change-Number: 21504
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Dec 2020 10:23:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201207/2444b0f3/attachment.htm>


More information about the gerrit-log mailing list