Change in osmo-gsm-tester[master]: wait_no_raise(): set default args

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Sun Dec 6 14:53:38 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21508 )

Change subject: wait_no_raise(): set default args
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> I don't like this really much. I would favour only using the wait() method and handling the exception in the test. Let's keep the amount of APIs we need to maintain in tests as small as possible please.

I looked and can in fact just use wait().

But actually it was *you* who added wait_no_raise to the testenv explicitly as test API in 927344b4.
Admittedly three years ago.

I guess you should remove that then
(or apply this patch so that wait_no_raise is sanely usable)


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21508
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I225a175b25c5c148ef5e23d2184f5d1aa2f4188a
Gerrit-Change-Number: 21508
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 06 Dec 2020 14:53:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201206/fffafa0e/attachment.htm>


More information about the gerrit-log mailing list