Change in osmo-sgsn[master]: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21477 )

Change subject: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs
......................................................................

gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
---
M src/gbproxy/gb_proxy.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index a4ad7af..8b103c8 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1017,8 +1017,10 @@
 	struct gbproxy_peer *from_peer = NULL;
 	uint16_t bvci;
 
-	if (!TLVP_PRESENT(tp, BSSGP_IE_BVCI))
-		return 0;
+	if (!TLVP_PRESENT(tp, BSSGP_IE_BVCI) || !TLVP_PRESENT(tp, BSSGP_IE_CAUSE)) {
+		rate_ctr_inc(&cfg->ctrg->ctr[GBPROX_GLOB_CTR_PROTO_ERR_BSS]);
+		return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
+	}
 
 	bvci = ntohs(tlvp_val16_unal(tp, BSSGP_IE_BVCI));
 	LOGP(DGPRS, LOGL_INFO, "NSE(%05u) Rx BVC RESET (BVCI=%05u)\n", nsei, bvci);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21477
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
Gerrit-Change-Number: 21477
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201205/65431bf3/attachment.htm>