Change in libosmocore[master]: bssgp: Add osmo_tlv_prot_def for BSSGP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Dec 4 20:52:45 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21544 )

Change subject: bssgp: Add osmo_tlv_prot_def for BSSGP
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21544/1/src/gb/gprs_bssgp_util.c 
File src/gb/gprs_bssgp_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/21544/1/src/gb/gprs_bssgp_util.c@209 
PS1, Line 209: static const uint8_t crt_bss_pfc_nack_ies[] = { BSSGP_IE_TLLI, BSSGP_IE_PACKET_FLOW_ID, BSSGP_IE_CAUSE };
> feeling like I'm looking at wireshark code ;) […]
I'm not sure I understand your suggestion.  Feel free to try it with another of our many protocol definitions as an example?


https://gerrit.osmocom.org/c/libosmocore/+/21544/1/src/gb/gprs_bssgp_util.c@239 
PS1, Line 239: 		[BSSGP_PDUT_DL_UNITDATA] = MSG_DEF("DL-UNITDAT", dl_ud_ies),
> missing A in data.
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21544
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7e4226463f3c935134b5c2c737696fbfd1dd5815
Gerrit-Change-Number: 21544
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Dec 2020 20:52:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/d753332f/attachment.htm>


More information about the gerrit-log mailing list