Change in osmo-sgsn[master]: gbproxy: Send BVC-BLOCK for PTP BVC to SGSN when BSS resets BVCI=0

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21476 )

Change subject: gbproxy: Send BVC-BLOCK for PTP BVC to SGSN when BSS resets BVCI=0
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-sgsn/+/21476/4/src/gbproxy/gb_proxy.c 
File src/gbproxy/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21476/4/src/gbproxy/gb_proxy.c@1005 
PS4, Line 1005: 			if (llist_empty(&nse->bts_peers)) {
> looks like it may make sense to have this inside gbproxy_peer_free? I assume llist_del nse->bts_peer […]
I'm not quite sure what your comment refers to exactly.

gbproxy_peer_free() is called on other occasions as well when we don't want to sent a RESET_ACK

But thanks to this I just noticed that we only want to have this code path on BLOCK_ACK



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21476
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I48f1c148bc5c7c9a49b789dac78f76c2aa7baff8
Gerrit-Change-Number: 21476
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: daniel <daniel at totalueberwachung.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: daniel <daniel at totalueberwachung.de>
Gerrit-Comment-Date: Fri, 04 Dec 2020 19:05:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/4ba9f91d/attachment.htm>