This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523 ) Change subject: add handover_2G suite, with handover.py test ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/src/osmo_gsm_tester/testenv.py File src/osmo_gsm_tester/testenv.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/src/osmo_gsm_tester/testenv.py@34 PS2, Line 34: test = None This looks like a separate commit. BTW, my intention was to probably drop test global object, so I'd rather remove it from setup() and use tenv.test() from the test. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/handover-suites.conf File sysmocom/handover-suites.conf: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/handover-suites.conf@1 PS2, Line 1: - handover_2G:nanobts+bts1-oc2g Why not adding it to the defaults-suites.conf instead/too? https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/suites/handover_2G/handover.py File sysmocom/suites/handover_2G/handover.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/suites/handover_2G/handover.py@91 PS2, Line 91: with bsc.ctrl() as bsc_ctrl: so basically you keep the object until the end of the test. So IIUC there's no win in having "with" used here and you get everything indented instead. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/suites/handover_2G/handover.py@118 PS2, Line 118: wait_no_raise(counters.changed, timeout=20) try: wait() except: pass BTW why don't you let the exception do its stuff directly and exit the test? I don't really see the the point for all this. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I0b2671304165a1aaae2b386af46fbd8b098e3bd8 Gerrit-Change-Number: 21523 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 04 Dec 2020 18:54:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/eb84144e/attachment.htm>