This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21539 ) Change subject: gbproxy: Allow gbproxy_nse_free(NULL) ...................................................................... gbproxy: Allow gbproxy_nse_free(NULL) Calling free() with a null-pointer is usually supported and does nothing. Change gbproxy_{peer,nse}_free() to reflect that behaviour. Change-Id: Ia32084f81ca8f8cb9ddea3adabd4b44fd766f1c7 --- M src/gbproxy/gb_proxy_peer.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/gbproxy/gb_proxy_peer.c b/src/gbproxy/gb_proxy_peer.c index 2b28dd5..ea5fe1e 100644 --- a/src/gbproxy/gb_proxy_peer.c +++ b/src/gbproxy/gb_proxy_peer.c @@ -242,7 +242,8 @@ void gbproxy_peer_free(struct gbproxy_peer *peer) { - OSMO_ASSERT(peer); + if (!peer) + return; llist_del(&peer->list); osmo_timer_del(&peer->clean_stale_timer); @@ -305,7 +306,8 @@ void gbproxy_nse_free(struct gbproxy_nse *nse) { struct gbproxy_peer *peer, *tmp; - OSMO_ASSERT(nse); + if (!nse) + return; llist_del(&nse->list); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia32084f81ca8f8cb9ddea3adabd4b44fd766f1c7 Gerrit-Change-Number: 21539 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/b6fc5361/attachment.htm>