This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21521 ) Change subject: use ctrl.get_var() instead of do_get() with code dup ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Please squash this commit with the previous one if possible, otherwise it's not celar what those functions are for. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21521/2/src/osmo_gsm_tester/obj/bsc_osmo.py File src/osmo_gsm_tester/obj/bsc_osmo.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21521/2/src/osmo_gsm_tester/obj/bsc_osmo.py@219 PS2, Line 219: oml_state = ctrl.get_var(OsmoBscCtrl.BTS_OML_STATE_VAR % bts_num) lol I first understood this as a modulus operation and I was not understanding what was going on here. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I8dd6140787c6e84dff0882a1c9d5be4bdd3bbc43 Gerrit-Change-Number: 21521 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 04 Dec 2020 18:30:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/f3c4bf99/attachment.htm>