This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21534 ) Change subject: Introduce 'osmo_tlv_prot' abstraction for validation of TLV protocols ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/21534/1/src/gsm/tlv_parser.c File src/gsm/tlv_parser.c: https://gerrit.osmocom.org/c/libosmocore/+/21534/1/src/gsm/tlv_parser.c@641 PS1, Line 641: } else { > IIRC get_value_string can already return a similar "unknown 0x%x" string, so you can probably drop t […] but the pdef->msgt_names is optional, by intention. The value_string for message type is no longer needed with this new API. Instead, we have a more efficient way by looking up pdef->msg_def[x].name without any linear iteration. However, since most existing protocols have those old value_string arrays, we keep the option until everything is eventually converted. So the else-clause-with-snprintf is needed. https://gerrit.osmocom.org/c/libosmocore/+/21534/1/src/gsm/tlv_parser.c@690 PS1, Line 690: min_len = pdef->ie_def[i].min_len; > May it make sense to instead have a min_len max_len range? with some special value NO_MAX_LEN 0xffff […] I think in general it's ok to simply ignore any extraneous length. Sure, one could make it even tighter, but I also think some IEs are getting longer and longer in each 3GPP release of the spec, so checking for a maximum length might be detrimental to future compatibility. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If1e1d9adfa141ca86001dbd62a6a339f9bf9a912 Gerrit-Change-Number: 21534 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 04 Dec 2020 17:58:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/718e33f2/attachment.htm>