Change in libosmocore[master]: Introduce 'osmo_tlv_prot' abstraction for validation of TLV protocols

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21534 )

Change subject: Introduce 'osmo_tlv_prot' abstraction for validation of TLV protocols
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21534/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/21534/1//COMMIT_MSG@14 
PS1, Line 14: imperative verification across virtually all the protocols iwe
iwe -> we


https://gerrit.osmocom.org/c/libosmocore/+/21534/1/include/osmocom/gsm/tlv.h 
File include/osmocom/gsm/tlv.h:

https://gerrit.osmocom.org/c/libosmocore/+/21534/1/include/osmocom/gsm/tlv.h@644 
PS1, Line 644: 	/*! minimum length = name of IEs, for each 8-bit tag */
I don't really get what you mean here.


https://gerrit.osmocom.org/c/libosmocore/+/21534/1/src/gsm/tlv_parser.c 
File src/gsm/tlv_parser.c:

https://gerrit.osmocom.org/c/libosmocore/+/21534/1/src/gsm/tlv_parser.c@641 
PS1, Line 641: 	} else {
IIRC get_value_string can already return a similar "unknown 0x%x" string, so you can probably drop this else condition.


https://gerrit.osmocom.org/c/libosmocore/+/21534/1/src/gsm/tlv_parser.c@690 
PS1, Line 690: 		min_len = pdef->ie_def[i].min_len;
May it make sense to instead have a min_len max_len range? with some special value NO_MAX_LEN 0xffff meaning max is not to be checked.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21534
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If1e1d9adfa141ca86001dbd62a6a339f9bf9a912
Gerrit-Change-Number: 21534
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Dec 2020 16:06:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/059c1984/attachment.htm>