Change in libosmocore[master]: gprs_ns2: Use TLVP_PRES_LEN instead of TLVP_PRESENT

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Dec 4 09:44:21 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21494 )

Change subject: gprs_ns2: Use TLVP_PRES_LEN instead of TLVP_PRESENT
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21494/2/src/gb/gprs_ns2.c 
File src/gb/gprs_ns2.c:

https://gerrit.osmocom.org/c/libosmocore/+/21494/2/src/gb/gprs_ns2.c@596 
PS2, Line 596: 		LOGP(DLNS, LOGL_NOTICE, "NSEI=%u Rejecting message without NSVCI. Tx NS STATUS (cause=%s)\n",
> This logging statement looks wrong: we check if NSEI is present, and log that NSVCI is absent?
I agree, but it is not changed by the patch at hand.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21494
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4c438bc82ea6a48243db568f96a234adf784dc0b
Gerrit-Change-Number: 21494
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Dec 2020 09:44:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/33e35ba5/attachment.htm>


More information about the gerrit-log mailing list