Change in osmo-bts[master]: vty: add commands for Downlink power control

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Dec 3 23:00:02 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21438 )

Change subject: vty: add commands for Downlink power control
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/21438/1/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21438/1/src/common/vty.c@655 
PS1, Line 655: 	i
> Ok, but I still see no arguments *why* strcmp() is preferred, and what's wrong with checking the fir […]
because the condition for the relative clause is that the specified string was "uplink" or "downlink'.  Checking only the first letter makes it harder to read / figure out what is the intent here, and looks like an over-optimization with no benefit.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21438
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I61efbe177aa06584cd7412640b888913de6e8f9d
Gerrit-Change-Number: 21438
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Dec 2020 23:00:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/787c3413/attachment.htm>


More information about the gerrit-log mailing list