Change in osmo-bsc[master]: Handle BTS/BBTRANSC Get Attributes (Ack) in NM FSMs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Dec 3 20:27:58 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21502 )

Change subject: Handle BTS/BBTRANSC Get Attributes (Ack) in NM FSMs
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/21502/1/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/21502/1/include/osmocom/bsc/gsm_data.h@402 
PS1, Line 402: 	bool get_attr_sent;
Hmm, I thought the idea of FSMs is to replace state variables and boolean flags... AFAIR, it's not an optional part of the bootstrapping process, so I would expect both request and response to be handled within a single state without any additional flags. Don't get me wrong, I am not familiar with the OML as good as you, but this *looks* like a fault in the FSM design / architecture.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21502
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8ec39c7e1f956ffce9aecd58a5590c43200ba086
Gerrit-Change-Number: 21502
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Thu, 03 Dec 2020 20:27:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/cccf18ef/attachment.htm>


More information about the gerrit-log mailing list